fix: use Node 24 and remove registry-url for npm OIDC publishing#175
Merged
Conversation
Node 22 ships npm 10.x which does not support OIDC trusted publishing
(requires npm 11.5.1+). Node 24 ships npm 11+.
The registry-url param in setup-node creates an .npmrc with
//registry.npmjs.org/:_authToken=${NODE_AUTH_TOKEN}. Since no
NODE_AUTH_TOKEN is set (we removed it in #174), npm uses an empty
token instead of auto-detecting the OIDC environment. Removing
registry-url lets npm default to registry.npmjs.org and perform
OIDC token exchange correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the npm trusted publishing failure introduced in #174. The publish step was failing with
E404 Not Found/Access token expired or revoked.Root causes:
registry-urlinsetup-nodecreates an.npmrccontaining//registry.npmjs.org/:_authToken=${NODE_AUTH_TOKEN}— sinceNODE_AUTH_TOKENwas removed in chore: switch npm publish to OIDC trusted publisher #174, npm uses an empty token instead of auto-detecting the OIDC environment for trusted publishingChanges:
node-versionfrom'22'to'24'registry-urlfromsetup-node(npm defaults to registry.npmjs.org anyway)Build, test, and lint all pass.